Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd compression support #1532

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Add zstd compression support #1532

merged 12 commits into from
Nov 15, 2023

Conversation

QuentinPerez
Copy link
Contributor

Motivation

See #1236

Solution

Based on the work of https://github.com/martinabeleda #1371

Add zstd as a CompressionEncoding and as a feature/optional dependency.

New to rust so looking for some feedback on my approach to testing.

@QuentinPerez
Copy link
Contributor Author

@LucioFranco all green :)

@QuentinPerez
Copy link
Contributor Author

@LucioFranco is it mergeable ?

@QuentinPerez
Copy link
Contributor Author

Hello @LucioFranco,

I hope you're doing well and enjoying your time working on @tursodatabase with our friend Glauber! 👋

I've noticed that you are currently maintaining this repository "alone." Is there anyone else who might be able to step in and assist with this project? Maintaining an open-source repository can be a challenging task, and I understand the significant amount of time required to keep it alive. However, it's concerning to see numerous open PRs languishing in silence.

I hope we can find a solution that benefits both you and the community. Your dedication to this project is highly appreciated, and I'm confident that we can find a way to keep it going strong.

Thank you for your hard work and commitment to open source.

@lcmgh
Copy link

lcmgh commented Oct 26, 2023

I'd love to see that feature as well and I am curious about if anyone of you came up with some benchmarks. I am curious about the performance increase gzip vs zstd in case of two services that are located close to each other.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!!! Thanks

@LucioFranco
Copy link
Member

I've noticed that you are currently maintaining this repository "alone." Is there anyone else who might be able to step in and assist with this project? Maintaining an open-source repository can be a challenging task, and I understand the significant amount of time required to keep it alive. However, it's concerning to see numerous open PRs languishing in silence.

I absolutely would love help! I've been trying to find someone else to help me with both this and prost for a good 3 years now with no success.

@LucioFranco LucioFranco added this pull request to the merge queue Nov 15, 2023
Merged via the queue into hyperium:master with commit e8cb48f Nov 15, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants